Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update okapi - ignore bad exif data #707

Closed
wants to merge 1 commit into from
Closed

update okapi - ignore bad exif data #707

wants to merge 1 commit into from

Conversation

following5
Copy link
Contributor

Fix for this problem:

OKAPI caught the following exception while executing API method request.
This is an error in OUR code and should be fixed. Please contact the
developer of the module that threw this error. Thanks!

ERROR MESSAGE
ErrorException:
exif_read_data(Z
): Illegal IFD size

--- Stack trace ---
#0 [internal function]: okapi\core\OkapiErrorHandler::handle(2, 'exif_read_data(...', '/var/www/openca...', 275, Array)
#1 /var/www/opencaching.de/www/code/htdocs/vendor/opencaching/okapi/okapi/services/logs/images/add/WebService.php(275): exif_read_data('data://image/jp...')
#2 /var/www/opencaching.de/www/code/htdocs/vendor/opencaching/okapi/okapi/services/logs/images/add/WebService.php(164): okapi\services\logs\images\add\WebService::postprocess_image('/9j/4QA0RXhpZgA...', Resource id #86, 2, 934, 703)
#3 /var/www/opencaching.de/www/code/htdocs/vendor/opencaching/okapi/okapi/services/logs/images/add/WebService.php(405): okapi\services\logs\images\add\WebService::_call(Object(okapi\core\Request\OkapiHttpRequest))
#4 [internal function]: okapi\services\logs\images\add\WebService::call(Object(okapi\core\Request\OkapiHttpRequest))
#5 /var/www/opencaching.de/www/code/htdocs/vendor/opencaching/okapi/okapi/core/OkapiServiceRunner.php(139): call_user_func(Array, Object(okapi\core\Request\OkapiHttpRequest))
#6 /var/www/opencaching.de/www/code/htdocs/vendor/opencaching/okapi/okapi/views/method_call/View.php(19): okapi\core\OkapiServiceRunner::call('services/logs/i...', Object(okapi\core\Request\OkapiHttpRequest))
#7 [internal function]: okapi\views\method_call\View::call('services/logs/i...')
#8 /var/www/opencaching.de/www/code/htdocs/vendor/opencaching/okapi/okapi/OkapiScriptEntryPointController.php(51): call_user_func_array(Array, Array)
#9 /var/www/opencaching.de/www/code/htdocs/vendor/opencaching/okapi/okapi/index.php(50): okapi\OkapiScriptEntryPointController::dispatch_request('/okapi/services...')
#10 /var/www/opencaching.de/www/code/htdocs/okapi/index.php(7): require_once('/var/www/openca...')
#11 {main}

--- OKAPI method called ---
/okapi/services/logs/images/add

--- OKAPI version ---
1684 (8b1f529bf3f46aaad59ca83f0f95b37c20e71fa0)

--- Request headers ---
Accept-Charset: utf-8,iso-8859-1;q=0.8,utf-16;q=0.8,;q=0.7
Accept-Language: en-US,
;q=0.9
X-Requested-With: XMLHttpRequest
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Content-Type: application/x-www-form-urlencoded
Content-Length: 1020720
Host: www.opencaching.de
Connection: Keep-Alive
Accept-Encoding: gzip
.

@codecov
Copy link

codecov bot commented Dec 16, 2017

Codecov Report

Merging #707 into development will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #707      +/-   ##
==============================================
+ Coverage         5.41%   5.42%   +<.01%     
==============================================
  Files              255     255              
  Lines            15967   15977      +10     
==============================================
+ Hits               865     866       +1     
- Misses           15102   15111       +9
Impacted Files Coverage Δ
htdocs/okapi/meta.php 100% <100%> (ø) ⬆️
...cs/src/Oc/GeoCache/Controller/QrCodeController.php 20% <0%> (ø) ⬆️
htdocs/src/Oc/Validator/Validator.php 0% <0%> (ø) ⬆️
...dNotes/Validator/Constraints/DateTimeValidator.php 0% <0%> (ø) ⬆️
htdocs/src/Oc/AbstractController.php 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbe9d0...0560c71. Read the comment docs.

@teiling88
Copy link
Member

This change has no impact to the installed okapi version. It changes only the display value. Seems to be well tested.

If you want an easy and tested solution to update the okapi package use the following psh command:

./psh.phar update-okapi-package

@teiling88 teiling88 closed this Dec 17, 2017
@following5 following5 deleted the okapi-update branch September 18, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants